mirror of
https://github.com/onyx-dot-app/onyx.git
synced 2026-03-25 09:32:45 +00:00
Compare commits
2 Commits
multi-mode
...
multi-mode
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
0f2a83f9cd | ||
|
|
40f1189989 |
@@ -159,6 +159,10 @@ export interface Message {
|
||||
overridden_model?: string;
|
||||
stopReason?: StreamStopReason | null;
|
||||
|
||||
// Multi-model answer generation
|
||||
preferredResponseId?: number | null;
|
||||
modelDisplayName?: string | null;
|
||||
|
||||
// new gen
|
||||
packets: Packet[];
|
||||
packetCount?: number; // Tracks packet count for React memo comparison (avoids reading from mutated array)
|
||||
@@ -231,6 +235,9 @@ export interface BackendMessage {
|
||||
parentMessageId: number | null;
|
||||
refined_answer_improvement: boolean | null;
|
||||
is_agentic: boolean | null;
|
||||
// Multi-model answer generation
|
||||
preferred_response_id: number | null;
|
||||
model_display_name: string | null;
|
||||
}
|
||||
|
||||
export interface MessageResponseIDInfo {
|
||||
@@ -238,6 +245,12 @@ export interface MessageResponseIDInfo {
|
||||
reserved_assistant_message_id: number; // TODO: rename to agent — https://linear.app/onyx-app/issue/ENG-3766
|
||||
}
|
||||
|
||||
export interface MultiModelMessageResponseIDInfo {
|
||||
user_message_id: number | null;
|
||||
reserved_assistant_message_ids: number[];
|
||||
model_names: string[];
|
||||
}
|
||||
|
||||
export interface UserKnowledgeFilePacket {
|
||||
user_files: FileDescriptor[];
|
||||
}
|
||||
|
||||
149
web/src/app/app/message/MultiModelPanel.tsx
Normal file
149
web/src/app/app/message/MultiModelPanel.tsx
Normal file
@@ -0,0 +1,149 @@
|
||||
"use client";
|
||||
|
||||
import { useCallback } from "react";
|
||||
import { Button } from "@opal/components";
|
||||
import { Hoverable } from "@opal/core";
|
||||
import { SvgEyeClosed, SvgMoreHorizontal, SvgX } from "@opal/icons";
|
||||
import Text from "@/refresh-components/texts/Text";
|
||||
import { getProviderIcon } from "@/app/admin/configuration/llm/utils";
|
||||
import AgentMessage, {
|
||||
AgentMessageProps,
|
||||
} from "@/app/app/message/messageComponents/AgentMessage";
|
||||
import { cn } from "@/lib/utils";
|
||||
|
||||
export interface MultiModelPanelProps {
|
||||
/** Index of this model in the selectedModels array (used for Hoverable group key) */
|
||||
modelIndex: number;
|
||||
/** Provider name for icon lookup */
|
||||
provider: string;
|
||||
/** Model name for icon lookup and display */
|
||||
modelName: string;
|
||||
/** Display-friendly model name */
|
||||
displayName: string;
|
||||
/** Whether this panel is the preferred/selected response */
|
||||
isPreferred: boolean;
|
||||
/** Whether this panel is currently hidden */
|
||||
isHidden: boolean;
|
||||
/** Whether this is a non-preferred panel in selection mode (pushed off-screen) */
|
||||
isNonPreferredInSelection: boolean;
|
||||
/** Callback when user clicks this panel to select as preferred */
|
||||
onSelect: () => void;
|
||||
/** Callback to hide/show this panel */
|
||||
onToggleVisibility: () => void;
|
||||
/** Props to pass through to AgentMessage */
|
||||
agentMessageProps: AgentMessageProps;
|
||||
}
|
||||
|
||||
export default function MultiModelPanel({
|
||||
modelIndex,
|
||||
provider,
|
||||
modelName,
|
||||
displayName,
|
||||
isPreferred,
|
||||
isHidden,
|
||||
isNonPreferredInSelection,
|
||||
onSelect,
|
||||
onToggleVisibility,
|
||||
agentMessageProps,
|
||||
}: MultiModelPanelProps) {
|
||||
const ProviderIcon = getProviderIcon(provider, modelName);
|
||||
|
||||
const handlePanelClick = useCallback(() => {
|
||||
if (!isHidden) {
|
||||
onSelect();
|
||||
}
|
||||
}, [isHidden, onSelect]);
|
||||
|
||||
// Hidden/collapsed panel — compact strip: icon + strikethrough name + eye icon
|
||||
if (isHidden) {
|
||||
return (
|
||||
<div className="flex items-center gap-1.5 rounded-08 bg-background-tint-00 px-2 py-1 opacity-50">
|
||||
<div className="flex items-center justify-center size-5 shrink-0">
|
||||
<ProviderIcon size={16} />
|
||||
</div>
|
||||
<Text secondaryBody text02 nowrap className="line-through">
|
||||
{displayName}
|
||||
</Text>
|
||||
<Button
|
||||
prominence="tertiary"
|
||||
icon={SvgEyeClosed}
|
||||
size="2xs"
|
||||
onClick={onToggleVisibility}
|
||||
tooltip="Show response"
|
||||
/>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
const hoverGroup = `panel-${modelIndex}`;
|
||||
|
||||
return (
|
||||
<Hoverable.Root group={hoverGroup}>
|
||||
<div
|
||||
className="flex flex-col min-w-0 gap-3 cursor-pointer"
|
||||
onClick={handlePanelClick}
|
||||
>
|
||||
{/* Panel header */}
|
||||
<div
|
||||
className={cn(
|
||||
"flex items-center gap-1.5 rounded-12 px-2 py-1",
|
||||
isPreferred ? "bg-background-tint-02" : "bg-background-tint-00"
|
||||
)}
|
||||
>
|
||||
<div className="flex items-center justify-center size-5 shrink-0">
|
||||
<ProviderIcon size={16} />
|
||||
</div>
|
||||
<Text mainUiAction text04 nowrap className="flex-1 min-w-0 truncate">
|
||||
{displayName}
|
||||
</Text>
|
||||
{isPreferred && (
|
||||
<Text secondaryBody nowrap className="text-action-link-05 shrink-0">
|
||||
Preferred Response
|
||||
</Text>
|
||||
)}
|
||||
<Button
|
||||
prominence="tertiary"
|
||||
icon={SvgMoreHorizontal}
|
||||
size="2xs"
|
||||
tooltip="More"
|
||||
onClick={(e) => e.stopPropagation()}
|
||||
/>
|
||||
<Button
|
||||
prominence="tertiary"
|
||||
icon={SvgX}
|
||||
size="2xs"
|
||||
onClick={(e) => {
|
||||
e.stopPropagation();
|
||||
onToggleVisibility();
|
||||
}}
|
||||
tooltip="Hide response"
|
||||
/>
|
||||
</div>
|
||||
|
||||
{/* "Select This Response" hover affordance */}
|
||||
{!isPreferred && !isNonPreferredInSelection && (
|
||||
<Hoverable.Item group={hoverGroup} variant="opacity-on-hover">
|
||||
<div className="flex justify-center pointer-events-none">
|
||||
<div className="flex items-center h-6 bg-background-tint-00 rounded-08 px-1 shadow-sm">
|
||||
<Text
|
||||
secondaryBody
|
||||
className="font-semibold text-text-03 px-1 whitespace-nowrap"
|
||||
>
|
||||
Select This Response
|
||||
</Text>
|
||||
</div>
|
||||
</div>
|
||||
</Hoverable.Item>
|
||||
)}
|
||||
|
||||
{/* Response body */}
|
||||
<div className={cn(isNonPreferredInSelection && "pointer-events-none")}>
|
||||
<AgentMessage
|
||||
{...agentMessageProps}
|
||||
hideFooter={isNonPreferredInSelection}
|
||||
/>
|
||||
</div>
|
||||
</div>
|
||||
</Hoverable.Root>
|
||||
);
|
||||
}
|
||||
229
web/src/app/app/message/MultiModelResponseView.tsx
Normal file
229
web/src/app/app/message/MultiModelResponseView.tsx
Normal file
@@ -0,0 +1,229 @@
|
||||
"use client";
|
||||
|
||||
import { useState, useCallback, useMemo } from "react";
|
||||
import { Packet } from "@/app/app/services/streamingModels";
|
||||
import { FullChatState } from "@/app/app/message/messageComponents/interfaces";
|
||||
import { FeedbackType, Message } from "@/app/app/interfaces";
|
||||
import { LlmManager } from "@/lib/hooks";
|
||||
import { RegenerationFactory } from "@/app/app/message/messageComponents/AgentMessage";
|
||||
import MultiModelPanel from "@/app/app/message/MultiModelPanel";
|
||||
import { cn } from "@/lib/utils";
|
||||
|
||||
export interface MultiModelResponse {
|
||||
modelIndex: number;
|
||||
provider: string;
|
||||
modelName: string;
|
||||
displayName: string;
|
||||
packets: Packet[];
|
||||
packetCount: number;
|
||||
nodeId: number;
|
||||
messageId?: number;
|
||||
isHighlighted?: boolean;
|
||||
currentFeedback?: FeedbackType | null;
|
||||
isGenerating?: boolean;
|
||||
}
|
||||
|
||||
export interface MultiModelResponseViewProps {
|
||||
responses: MultiModelResponse[];
|
||||
chatState: FullChatState;
|
||||
llmManager: LlmManager | null;
|
||||
onRegenerate?: RegenerationFactory;
|
||||
parentMessage?: Message | null;
|
||||
otherMessagesCanSwitchTo?: number[];
|
||||
onMessageSelection?: (nodeId: number) => void;
|
||||
}
|
||||
|
||||
export default function MultiModelResponseView({
|
||||
responses,
|
||||
chatState,
|
||||
llmManager,
|
||||
onRegenerate,
|
||||
parentMessage,
|
||||
otherMessagesCanSwitchTo,
|
||||
onMessageSelection,
|
||||
}: MultiModelResponseViewProps) {
|
||||
const [preferredIndex, setPreferredIndex] = useState<number | null>(null);
|
||||
const [hiddenPanels, setHiddenPanels] = useState<Set<number>>(new Set());
|
||||
|
||||
const isGenerating = useMemo(
|
||||
() => responses.some((r) => r.isGenerating),
|
||||
[responses]
|
||||
);
|
||||
|
||||
const visibleResponses = useMemo(
|
||||
() => responses.filter((r) => !hiddenPanels.has(r.modelIndex)),
|
||||
[responses, hiddenPanels]
|
||||
);
|
||||
|
||||
const hiddenResponses = useMemo(
|
||||
() => responses.filter((r) => hiddenPanels.has(r.modelIndex)),
|
||||
[responses, hiddenPanels]
|
||||
);
|
||||
|
||||
const toggleVisibility = useCallback(
|
||||
(modelIndex: number) => {
|
||||
setHiddenPanels((prev) => {
|
||||
const next = new Set(prev);
|
||||
if (next.has(modelIndex)) {
|
||||
next.delete(modelIndex);
|
||||
} else {
|
||||
// Don't hide the last visible panel
|
||||
const visibleCount = responses.length - next.size;
|
||||
if (visibleCount <= 1) return prev;
|
||||
next.add(modelIndex);
|
||||
}
|
||||
return next;
|
||||
});
|
||||
},
|
||||
[responses.length]
|
||||
);
|
||||
|
||||
const handleSelectPreferred = useCallback(
|
||||
(modelIndex: number) => {
|
||||
setPreferredIndex(modelIndex);
|
||||
const response = responses[modelIndex];
|
||||
if (!response) return;
|
||||
// Sync with message tree — mark this response as the latest child
|
||||
// so the next message chains from it.
|
||||
if (onMessageSelection) {
|
||||
onMessageSelection(response.nodeId);
|
||||
}
|
||||
},
|
||||
[responses, onMessageSelection]
|
||||
);
|
||||
|
||||
// Selection mode when preferred is set and not generating
|
||||
const showSelectionMode =
|
||||
preferredIndex !== null && !isGenerating && visibleResponses.length > 1;
|
||||
|
||||
// Build common panel props
|
||||
const buildPanelProps = useCallback(
|
||||
(response: MultiModelResponse, isNonPreferred: boolean) => ({
|
||||
modelIndex: response.modelIndex,
|
||||
provider: response.provider,
|
||||
modelName: response.modelName,
|
||||
displayName: response.displayName,
|
||||
isPreferred: preferredIndex === response.modelIndex,
|
||||
isHidden: false as const,
|
||||
isNonPreferredInSelection: isNonPreferred,
|
||||
onSelect: () => handleSelectPreferred(response.modelIndex),
|
||||
onToggleVisibility: () => toggleVisibility(response.modelIndex),
|
||||
agentMessageProps: {
|
||||
rawPackets: response.packets,
|
||||
packetCount: response.packetCount,
|
||||
chatState,
|
||||
nodeId: response.nodeId,
|
||||
messageId: response.messageId,
|
||||
currentFeedback: response.currentFeedback,
|
||||
llmManager,
|
||||
otherMessagesCanSwitchTo,
|
||||
onMessageSelection,
|
||||
onRegenerate,
|
||||
parentMessage,
|
||||
},
|
||||
}),
|
||||
[
|
||||
preferredIndex,
|
||||
handleSelectPreferred,
|
||||
toggleVisibility,
|
||||
chatState,
|
||||
llmManager,
|
||||
otherMessagesCanSwitchTo,
|
||||
onMessageSelection,
|
||||
onRegenerate,
|
||||
parentMessage,
|
||||
]
|
||||
);
|
||||
|
||||
// Shared renderer for hidden panels (inline in the flex row)
|
||||
const renderHiddenPanels = () =>
|
||||
hiddenResponses.map((r) => (
|
||||
<div key={r.modelIndex} className="w-[240px] shrink-0">
|
||||
<MultiModelPanel
|
||||
modelIndex={r.modelIndex}
|
||||
provider={r.provider}
|
||||
modelName={r.modelName}
|
||||
displayName={r.displayName}
|
||||
isPreferred={false}
|
||||
isHidden
|
||||
isNonPreferredInSelection={false}
|
||||
onSelect={() => handleSelectPreferred(r.modelIndex)}
|
||||
onToggleVisibility={() => toggleVisibility(r.modelIndex)}
|
||||
agentMessageProps={buildPanelProps(r, false).agentMessageProps}
|
||||
/>
|
||||
</div>
|
||||
));
|
||||
|
||||
if (showSelectionMode) {
|
||||
// ── Selection Layout ──
|
||||
// Preferred stays at normal chat width, centered.
|
||||
// Non-preferred panels are pushed to the viewport edges and clip off-screen.
|
||||
const preferredIdx = visibleResponses.findIndex(
|
||||
(r) => r.modelIndex === preferredIndex
|
||||
);
|
||||
const preferred = visibleResponses[preferredIdx];
|
||||
const leftPanels = visibleResponses.slice(0, preferredIdx);
|
||||
const rightPanels = visibleResponses.slice(preferredIdx + 1);
|
||||
|
||||
// Non-preferred panel width and gap between panels
|
||||
const PANEL_W = 400;
|
||||
const GAP = 16;
|
||||
|
||||
return (
|
||||
<div className="w-full relative overflow-hidden">
|
||||
{/* Preferred — centered at normal chat width, in flow to set container height */}
|
||||
{preferred && (
|
||||
<div className="w-full max-w-[720px] min-w-[400px] mx-auto">
|
||||
<MultiModelPanel {...buildPanelProps(preferred, false)} />
|
||||
</div>
|
||||
)}
|
||||
|
||||
{/* Non-preferred on the left — anchored to the left of the preferred panel */}
|
||||
{leftPanels.map((r, i) => (
|
||||
<div
|
||||
key={r.modelIndex}
|
||||
className="absolute top-0"
|
||||
style={{
|
||||
width: `${PANEL_W}px`,
|
||||
// Right edge of this panel sits just left of the preferred panel
|
||||
right: `calc(50% + var(--app-page-main-content-width) / 2 + ${
|
||||
GAP + i * (PANEL_W + GAP)
|
||||
}px)`,
|
||||
}}
|
||||
>
|
||||
<MultiModelPanel {...buildPanelProps(r, true)} />
|
||||
</div>
|
||||
))}
|
||||
|
||||
{/* Non-preferred on the right — anchored to the right of the preferred panel */}
|
||||
{rightPanels.map((r, i) => (
|
||||
<div
|
||||
key={r.modelIndex}
|
||||
className="absolute top-0"
|
||||
style={{
|
||||
width: `${PANEL_W}px`,
|
||||
// Left edge of this panel sits just right of the preferred panel
|
||||
left: `calc(50% + var(--app-page-main-content-width) / 2 + ${
|
||||
GAP + i * (PANEL_W + GAP)
|
||||
}px)`,
|
||||
}}
|
||||
>
|
||||
<MultiModelPanel {...buildPanelProps(r, true)} />
|
||||
</div>
|
||||
))}
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
// ── Generation Layout (equal panels) ──
|
||||
return (
|
||||
<div className="flex gap-6 items-start justify-center">
|
||||
{visibleResponses.map((r) => (
|
||||
<div key={r.modelIndex} className="flex-1 min-w-[400px] max-w-[720px]">
|
||||
<MultiModelPanel {...buildPanelProps(r, false)} />
|
||||
</div>
|
||||
))}
|
||||
{renderHiddenPanels()}
|
||||
</div>
|
||||
);
|
||||
}
|
||||
@@ -49,6 +49,8 @@ export interface AgentMessageProps {
|
||||
parentMessage?: Message | null;
|
||||
// Duration in seconds for processing this message (agent messages only)
|
||||
processingDurationSeconds?: number;
|
||||
/** Hide the feedback/toolbar footer (used in multi-model non-preferred panels) */
|
||||
hideFooter?: boolean;
|
||||
}
|
||||
|
||||
// TODO: Consider more robust comparisons:
|
||||
@@ -76,7 +78,8 @@ function arePropsEqual(
|
||||
prev.parentMessage?.messageId === next.parentMessage?.messageId &&
|
||||
prev.llmManager?.isLoadingProviders ===
|
||||
next.llmManager?.isLoadingProviders &&
|
||||
prev.processingDurationSeconds === next.processingDurationSeconds
|
||||
prev.processingDurationSeconds === next.processingDurationSeconds &&
|
||||
prev.hideFooter === next.hideFooter
|
||||
// Skip: chatState.regenerate, chatState.setPresentingDocument,
|
||||
// most of llmManager, onMessageSelection (function/object props)
|
||||
);
|
||||
@@ -95,6 +98,7 @@ const AgentMessage = React.memo(function AgentMessage({
|
||||
onRegenerate,
|
||||
parentMessage,
|
||||
processingDurationSeconds,
|
||||
hideFooter,
|
||||
}: AgentMessageProps) {
|
||||
const markdownRef = useRef<HTMLDivElement>(null);
|
||||
const finalAnswerRef = useRef<HTMLDivElement>(null);
|
||||
@@ -326,7 +330,7 @@ const AgentMessage = React.memo(function AgentMessage({
|
||||
</div>
|
||||
|
||||
{/* Feedback buttons - only show when streaming and rendering complete */}
|
||||
{isComplete && (
|
||||
{isComplete && !hideFooter && (
|
||||
<MessageToolbar
|
||||
nodeId={nodeId}
|
||||
messageId={messageId}
|
||||
|
||||
@@ -12,6 +12,7 @@ import {
|
||||
FileChatDisplay,
|
||||
Message,
|
||||
MessageResponseIDInfo,
|
||||
MultiModelMessageResponseIDInfo,
|
||||
ResearchType,
|
||||
RetrievalType,
|
||||
StreamingError,
|
||||
@@ -96,6 +97,7 @@ export type PacketType =
|
||||
| FileChatDisplay
|
||||
| StreamingError
|
||||
| MessageResponseIDInfo
|
||||
| MultiModelMessageResponseIDInfo
|
||||
| StreamStopInfo
|
||||
| UserKnowledgeFilePacket
|
||||
| Packet;
|
||||
@@ -109,6 +111,13 @@ export type MessageOrigin =
|
||||
| "slackbot"
|
||||
| "unknown";
|
||||
|
||||
export interface LLMOverride {
|
||||
model_provider: string;
|
||||
model_version: string;
|
||||
temperature?: number;
|
||||
display_name?: string;
|
||||
}
|
||||
|
||||
export interface SendMessageParams {
|
||||
message: string;
|
||||
fileDescriptors?: FileDescriptor[];
|
||||
@@ -124,6 +133,8 @@ export interface SendMessageParams {
|
||||
modelProvider?: string;
|
||||
modelVersion?: string;
|
||||
temperature?: number;
|
||||
// Multi-model: send multiple LLM overrides for parallel generation
|
||||
llmOverrides?: LLMOverride[];
|
||||
// Origin of the message for telemetry tracking
|
||||
origin?: MessageOrigin;
|
||||
// Additional context injected into the LLM call but not stored/shown in chat.
|
||||
@@ -144,6 +155,7 @@ export async function* sendMessage({
|
||||
modelProvider,
|
||||
modelVersion,
|
||||
temperature,
|
||||
llmOverrides,
|
||||
origin,
|
||||
additionalContext,
|
||||
}: SendMessageParams): AsyncGenerator<PacketType, void, unknown> {
|
||||
@@ -165,6 +177,8 @@ export async function* sendMessage({
|
||||
model_version: modelVersion,
|
||||
}
|
||||
: null,
|
||||
// Multi-model: list of LLM overrides for parallel generation
|
||||
llm_overrides: llmOverrides ?? null,
|
||||
// Default to "unknown" for consistency with backend; callers should set explicitly
|
||||
origin: origin ?? "unknown",
|
||||
additional_context: additionalContext ?? null,
|
||||
@@ -188,6 +202,20 @@ export async function* sendMessage({
|
||||
yield* handleSSEStream<PacketType>(response, signal);
|
||||
}
|
||||
|
||||
export async function setPreferredResponse(
|
||||
userMessageId: number,
|
||||
preferredResponseId: number
|
||||
): Promise<Response> {
|
||||
return fetch("/api/chat/set-preferred-response", {
|
||||
method: "PUT",
|
||||
headers: { "Content-Type": "application/json" },
|
||||
body: JSON.stringify({
|
||||
user_message_id: userMessageId,
|
||||
preferred_response_id: preferredResponseId,
|
||||
}),
|
||||
});
|
||||
}
|
||||
|
||||
export async function nameChatSession(chatSessionId: string) {
|
||||
const response = await fetch("/api/chat/rename-chat-session", {
|
||||
method: "PUT",
|
||||
@@ -357,6 +385,9 @@ export function processRawChatHistory(
|
||||
overridden_model: messageInfo.overridden_model,
|
||||
packets: packetsForMessage || [],
|
||||
currentFeedback: messageInfo.current_feedback as FeedbackType | null,
|
||||
// Multi-model answer generation
|
||||
preferredResponseId: messageInfo.preferred_response_id ?? null,
|
||||
modelDisplayName: messageInfo.model_display_name ?? null,
|
||||
};
|
||||
|
||||
messages.set(messageInfo.message_id, message);
|
||||
|
||||
@@ -403,6 +403,7 @@ export interface Placement {
|
||||
turn_index: number;
|
||||
tab_index?: number; // For parallel tool calls - tools with same turn_index but different tab_index run in parallel
|
||||
sub_turn_index?: number | null;
|
||||
model_index?: number | null; // For multi-model answer generation - identifies which model produced this packet
|
||||
}
|
||||
|
||||
// Packet wrapper for streaming objects
|
||||
|
||||
232
web/src/hooks/useMultiModelChat.test.tsx
Normal file
232
web/src/hooks/useMultiModelChat.test.tsx
Normal file
@@ -0,0 +1,232 @@
|
||||
import { renderHook, act } from "@testing-library/react";
|
||||
import useMultiModelChat from "@/hooks/useMultiModelChat";
|
||||
import { LlmManager } from "@/lib/hooks";
|
||||
import { SelectedModel } from "@/refresh-components/popovers/ModelSelector";
|
||||
|
||||
// Mock buildLlmOptions — hook uses it internally for initialization.
|
||||
// Tests here focus on CRUD operations, not the initialization side-effect.
|
||||
jest.mock("@/refresh-components/popovers/LLMPopover", () => ({
|
||||
buildLlmOptions: jest.fn(() => []),
|
||||
}));
|
||||
|
||||
const makeLlmManager = (): LlmManager =>
|
||||
({
|
||||
llmProviders: [],
|
||||
currentLlm: { modelName: null, provider: null },
|
||||
isLoadingProviders: false,
|
||||
}) as unknown as LlmManager;
|
||||
|
||||
const makeModel = (provider: string, modelName: string): SelectedModel => ({
|
||||
name: provider,
|
||||
provider,
|
||||
modelName,
|
||||
displayName: `${provider}/${modelName}`,
|
||||
});
|
||||
|
||||
const GPT4 = makeModel("openai", "gpt-4");
|
||||
const CLAUDE = makeModel("anthropic", "claude-opus-4-6");
|
||||
const GEMINI = makeModel("google", "gemini-pro");
|
||||
const GPT4_TURBO = makeModel("openai", "gpt-4-turbo");
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// addModel
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
describe("addModel", () => {
|
||||
it("adds a model to an empty selection", () => {
|
||||
const { result } = renderHook(() => useMultiModelChat(makeLlmManager()));
|
||||
|
||||
act(() => {
|
||||
result.current.addModel(GPT4);
|
||||
});
|
||||
|
||||
expect(result.current.selectedModels).toHaveLength(1);
|
||||
expect(result.current.selectedModels[0]).toEqual(GPT4);
|
||||
});
|
||||
|
||||
it("does not add a duplicate model", () => {
|
||||
const { result } = renderHook(() => useMultiModelChat(makeLlmManager()));
|
||||
|
||||
act(() => {
|
||||
result.current.addModel(GPT4);
|
||||
result.current.addModel(GPT4); // duplicate
|
||||
});
|
||||
|
||||
expect(result.current.selectedModels).toHaveLength(1);
|
||||
});
|
||||
|
||||
it("enforces MAX_MODELS (3) cap", () => {
|
||||
const { result } = renderHook(() => useMultiModelChat(makeLlmManager()));
|
||||
|
||||
act(() => {
|
||||
result.current.addModel(GPT4);
|
||||
result.current.addModel(CLAUDE);
|
||||
result.current.addModel(GEMINI);
|
||||
result.current.addModel(GPT4_TURBO); // should be ignored
|
||||
});
|
||||
|
||||
expect(result.current.selectedModels).toHaveLength(3);
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// removeModel
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
describe("removeModel", () => {
|
||||
it("removes a model by index", () => {
|
||||
const { result } = renderHook(() => useMultiModelChat(makeLlmManager()));
|
||||
|
||||
act(() => {
|
||||
result.current.addModel(GPT4);
|
||||
result.current.addModel(CLAUDE);
|
||||
});
|
||||
|
||||
act(() => {
|
||||
result.current.removeModel(0); // remove GPT4
|
||||
});
|
||||
|
||||
expect(result.current.selectedModels).toHaveLength(1);
|
||||
expect(result.current.selectedModels[0]).toEqual(CLAUDE);
|
||||
});
|
||||
|
||||
it("handles out-of-range index gracefully", () => {
|
||||
const { result } = renderHook(() => useMultiModelChat(makeLlmManager()));
|
||||
|
||||
act(() => {
|
||||
result.current.addModel(GPT4);
|
||||
});
|
||||
|
||||
act(() => {
|
||||
result.current.removeModel(99); // no-op
|
||||
});
|
||||
|
||||
expect(result.current.selectedModels).toHaveLength(1);
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// replaceModel
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
describe("replaceModel", () => {
|
||||
it("replaces the model at the given index", () => {
|
||||
const { result } = renderHook(() => useMultiModelChat(makeLlmManager()));
|
||||
|
||||
act(() => {
|
||||
result.current.addModel(GPT4);
|
||||
result.current.addModel(CLAUDE);
|
||||
});
|
||||
|
||||
act(() => {
|
||||
result.current.replaceModel(0, GEMINI);
|
||||
});
|
||||
|
||||
expect(result.current.selectedModels[0]).toEqual(GEMINI);
|
||||
expect(result.current.selectedModels[1]).toEqual(CLAUDE);
|
||||
});
|
||||
|
||||
it("does not replace with a model already selected at another index", () => {
|
||||
const { result } = renderHook(() => useMultiModelChat(makeLlmManager()));
|
||||
|
||||
act(() => {
|
||||
result.current.addModel(GPT4);
|
||||
result.current.addModel(CLAUDE);
|
||||
});
|
||||
|
||||
act(() => {
|
||||
result.current.replaceModel(0, CLAUDE); // CLAUDE is already at index 1
|
||||
});
|
||||
|
||||
// Should be a no-op — GPT4 stays at index 0
|
||||
expect(result.current.selectedModels[0]).toEqual(GPT4);
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// isMultiModelActive
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
describe("isMultiModelActive", () => {
|
||||
it("is false with zero models", () => {
|
||||
const { result } = renderHook(() => useMultiModelChat(makeLlmManager()));
|
||||
expect(result.current.isMultiModelActive).toBe(false);
|
||||
});
|
||||
|
||||
it("is false with exactly one model", () => {
|
||||
const { result } = renderHook(() => useMultiModelChat(makeLlmManager()));
|
||||
|
||||
act(() => {
|
||||
result.current.addModel(GPT4);
|
||||
});
|
||||
|
||||
expect(result.current.isMultiModelActive).toBe(false);
|
||||
});
|
||||
|
||||
it("is true with two or more models", () => {
|
||||
const { result } = renderHook(() => useMultiModelChat(makeLlmManager()));
|
||||
|
||||
act(() => {
|
||||
result.current.addModel(GPT4);
|
||||
result.current.addModel(CLAUDE);
|
||||
});
|
||||
|
||||
expect(result.current.isMultiModelActive).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// buildLlmOverrides
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
describe("buildLlmOverrides", () => {
|
||||
it("returns empty array when no models selected", () => {
|
||||
const { result } = renderHook(() => useMultiModelChat(makeLlmManager()));
|
||||
expect(result.current.buildLlmOverrides()).toEqual([]);
|
||||
});
|
||||
|
||||
it("maps selectedModels to LLMOverride format", () => {
|
||||
const { result } = renderHook(() => useMultiModelChat(makeLlmManager()));
|
||||
|
||||
act(() => {
|
||||
result.current.addModel(GPT4);
|
||||
result.current.addModel(CLAUDE);
|
||||
});
|
||||
|
||||
const overrides = result.current.buildLlmOverrides();
|
||||
|
||||
expect(overrides).toHaveLength(2);
|
||||
expect(overrides[0]).toEqual({
|
||||
model_provider: "openai",
|
||||
model_version: "gpt-4",
|
||||
display_name: "openai/gpt-4",
|
||||
});
|
||||
expect(overrides[1]).toEqual({
|
||||
model_provider: "anthropic",
|
||||
model_version: "claude-opus-4-6",
|
||||
display_name: "anthropic/claude-opus-4-6",
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
// ---------------------------------------------------------------------------
|
||||
// clearModels
|
||||
// ---------------------------------------------------------------------------
|
||||
|
||||
describe("clearModels", () => {
|
||||
it("empties the selection", () => {
|
||||
const { result } = renderHook(() => useMultiModelChat(makeLlmManager()));
|
||||
|
||||
act(() => {
|
||||
result.current.addModel(GPT4);
|
||||
result.current.addModel(CLAUDE);
|
||||
});
|
||||
|
||||
act(() => {
|
||||
result.current.clearModels();
|
||||
});
|
||||
|
||||
expect(result.current.selectedModels).toHaveLength(0);
|
||||
expect(result.current.isMultiModelActive).toBe(false);
|
||||
});
|
||||
});
|
||||
191
web/src/hooks/useMultiModelChat.ts
Normal file
191
web/src/hooks/useMultiModelChat.ts
Normal file
@@ -0,0 +1,191 @@
|
||||
"use client";
|
||||
|
||||
import { useState, useCallback, useEffect, useMemo } from "react";
|
||||
import { SelectedModel } from "@/refresh-components/popovers/ModelSelector";
|
||||
import { LLMOverride } from "@/app/app/services/lib";
|
||||
import { LlmManager } from "@/lib/hooks";
|
||||
import { buildLlmOptions } from "@/refresh-components/popovers/LLMPopover";
|
||||
|
||||
const MAX_MODELS = 3;
|
||||
|
||||
export interface UseMultiModelChatReturn {
|
||||
/** Currently selected models for multi-model comparison. */
|
||||
selectedModels: SelectedModel[];
|
||||
/** Whether multi-model mode is active (>1 model selected). */
|
||||
isMultiModelActive: boolean;
|
||||
/** Add a model to the selection. */
|
||||
addModel: (model: SelectedModel) => void;
|
||||
/** Remove a model by index. */
|
||||
removeModel: (index: number) => void;
|
||||
/** Replace a model at a specific index with a new one. */
|
||||
replaceModel: (index: number, model: SelectedModel) => void;
|
||||
/** Clear all selected models. */
|
||||
clearModels: () => void;
|
||||
/** Build the LLMOverride[] array from selectedModels. */
|
||||
buildLlmOverrides: () => LLMOverride[];
|
||||
/**
|
||||
* Restore multi-model selection from model version strings (e.g. from chat history).
|
||||
* Matches against available llmOptions to reconstruct full SelectedModel objects.
|
||||
*/
|
||||
restoreFromModelNames: (modelNames: string[]) => void;
|
||||
/**
|
||||
* Switch to a single model by name (after user picks a preferred response).
|
||||
* Matches against llmOptions to find the full SelectedModel.
|
||||
*/
|
||||
selectSingleModel: (modelName: string) => void;
|
||||
}
|
||||
|
||||
export default function useMultiModelChat(
|
||||
llmManager: LlmManager
|
||||
): UseMultiModelChatReturn {
|
||||
const [selectedModels, setSelectedModels] = useState<SelectedModel[]>([]);
|
||||
const [defaultInitialized, setDefaultInitialized] = useState(false);
|
||||
|
||||
// Initialize with the default model from llmManager once providers load
|
||||
const llmOptions = useMemo(
|
||||
() =>
|
||||
llmManager.llmProviders ? buildLlmOptions(llmManager.llmProviders) : [],
|
||||
[llmManager.llmProviders]
|
||||
);
|
||||
|
||||
useEffect(() => {
|
||||
if (defaultInitialized) return;
|
||||
if (llmOptions.length === 0) return;
|
||||
const { currentLlm } = llmManager;
|
||||
// Don't initialize if currentLlm hasn't loaded yet
|
||||
if (!currentLlm.modelName) return;
|
||||
const match = llmOptions.find(
|
||||
(opt) =>
|
||||
opt.provider === currentLlm.provider &&
|
||||
opt.modelName === currentLlm.modelName
|
||||
);
|
||||
if (match) {
|
||||
setSelectedModels([
|
||||
{
|
||||
name: match.name,
|
||||
provider: match.provider,
|
||||
modelName: match.modelName,
|
||||
displayName: match.displayName,
|
||||
},
|
||||
]);
|
||||
setDefaultInitialized(true);
|
||||
}
|
||||
}, [llmOptions, llmManager.currentLlm, defaultInitialized, llmManager]);
|
||||
|
||||
const isMultiModelActive = selectedModels.length > 1;
|
||||
|
||||
const addModel = useCallback((model: SelectedModel) => {
|
||||
setSelectedModels((prev) => {
|
||||
if (prev.length >= MAX_MODELS) return prev;
|
||||
if (
|
||||
prev.some(
|
||||
(m) =>
|
||||
m.provider === model.provider && m.modelName === model.modelName
|
||||
)
|
||||
) {
|
||||
return prev;
|
||||
}
|
||||
return [...prev, model];
|
||||
});
|
||||
}, []);
|
||||
|
||||
const removeModel = useCallback((index: number) => {
|
||||
setSelectedModels((prev) => prev.filter((_, i) => i !== index));
|
||||
}, []);
|
||||
|
||||
const replaceModel = useCallback((index: number, model: SelectedModel) => {
|
||||
setSelectedModels((prev) => {
|
||||
// Don't replace with a model that's already selected elsewhere
|
||||
if (
|
||||
prev.some(
|
||||
(m, i) =>
|
||||
i !== index &&
|
||||
m.provider === model.provider &&
|
||||
m.modelName === model.modelName
|
||||
)
|
||||
) {
|
||||
return prev;
|
||||
}
|
||||
const next = [...prev];
|
||||
next[index] = model;
|
||||
return next;
|
||||
});
|
||||
}, []);
|
||||
|
||||
const clearModels = useCallback(() => {
|
||||
setSelectedModels([]);
|
||||
}, []);
|
||||
|
||||
const restoreFromModelNames = useCallback(
|
||||
(modelNames: string[]) => {
|
||||
if (modelNames.length < 2 || llmOptions.length === 0) return;
|
||||
const restored: SelectedModel[] = [];
|
||||
for (const name of modelNames) {
|
||||
// Try matching by modelName (raw version string like "claude-opus-4-6")
|
||||
// or by displayName (friendly name like "Claude Opus 4.6")
|
||||
const match = llmOptions.find(
|
||||
(opt) =>
|
||||
opt.modelName === name ||
|
||||
opt.displayName === name ||
|
||||
opt.name === name
|
||||
);
|
||||
if (match) {
|
||||
restored.push({
|
||||
name: match.name,
|
||||
provider: match.provider,
|
||||
modelName: match.modelName,
|
||||
displayName: match.displayName,
|
||||
});
|
||||
}
|
||||
}
|
||||
if (restored.length >= 2) {
|
||||
setSelectedModels(restored);
|
||||
setDefaultInitialized(true);
|
||||
}
|
||||
},
|
||||
[llmOptions]
|
||||
);
|
||||
|
||||
const selectSingleModel = useCallback(
|
||||
(modelName: string) => {
|
||||
if (llmOptions.length === 0) return;
|
||||
const match = llmOptions.find(
|
||||
(opt) =>
|
||||
opt.modelName === modelName ||
|
||||
opt.displayName === modelName ||
|
||||
opt.name === modelName
|
||||
);
|
||||
if (match) {
|
||||
setSelectedModels([
|
||||
{
|
||||
name: match.name,
|
||||
provider: match.provider,
|
||||
modelName: match.modelName,
|
||||
displayName: match.displayName,
|
||||
},
|
||||
]);
|
||||
}
|
||||
},
|
||||
[llmOptions]
|
||||
);
|
||||
|
||||
const buildLlmOverrides = useCallback((): LLMOverride[] => {
|
||||
return selectedModels.map((m) => ({
|
||||
model_provider: m.name,
|
||||
model_version: m.modelName,
|
||||
display_name: m.displayName,
|
||||
}));
|
||||
}, [selectedModels]);
|
||||
|
||||
return {
|
||||
selectedModels,
|
||||
isMultiModelActive,
|
||||
addModel,
|
||||
removeModel,
|
||||
replaceModel,
|
||||
clearModels,
|
||||
buildLlmOverrides,
|
||||
restoreFromModelNames,
|
||||
selectSingleModel,
|
||||
};
|
||||
}
|
||||
@@ -32,6 +32,12 @@ export interface FrostedDivProps extends React.HTMLAttributes<HTMLDivElement> {
|
||||
* Additional classes for the frost overlay element itself
|
||||
*/
|
||||
overlayClassName?: string;
|
||||
|
||||
/**
|
||||
* Additional classes for the outermost wrapper div (the `relative` container).
|
||||
* Useful for width propagation (e.g. `w-full`).
|
||||
*/
|
||||
wrapperClassName?: string;
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -60,13 +66,14 @@ export default function FrostedDiv({
|
||||
backdropBlur = "6px",
|
||||
borderRadius = "1rem",
|
||||
overlayClassName,
|
||||
wrapperClassName,
|
||||
className,
|
||||
style,
|
||||
children,
|
||||
...props
|
||||
}: FrostedDivProps) {
|
||||
return (
|
||||
<div className="relative">
|
||||
<div className={cn("relative", wrapperClassName)}>
|
||||
{/* Frost effect overlay - positioned behind content with bloom extending outward */}
|
||||
<div
|
||||
className={cn("absolute pointer-events-none", overlayClassName)}
|
||||
|
||||
469
web/src/refresh-components/popovers/ModelSelector.tsx
Normal file
469
web/src/refresh-components/popovers/ModelSelector.tsx
Normal file
@@ -0,0 +1,469 @@
|
||||
"use client";
|
||||
|
||||
import { useState, useMemo, useRef } from "react";
|
||||
import Popover, { PopoverMenu } from "@/refresh-components/Popover";
|
||||
import { LlmManager } from "@/lib/hooks";
|
||||
import { getProviderIcon } from "@/app/admin/configuration/llm/utils";
|
||||
import InputTypeIn from "@/refresh-components/inputs/InputTypeIn";
|
||||
import Text from "@/refresh-components/texts/Text";
|
||||
import { Button } from "@opal/components";
|
||||
import {
|
||||
SvgCheck,
|
||||
SvgChevronDown,
|
||||
SvgChevronRight,
|
||||
SvgColumn,
|
||||
SvgPlusCircle,
|
||||
SvgX,
|
||||
} from "@opal/icons";
|
||||
import { Section } from "@/layouts/general-layouts";
|
||||
import {
|
||||
LLMOption,
|
||||
LLMOptionGroup,
|
||||
} from "@/refresh-components/popovers/interfaces";
|
||||
import {
|
||||
buildLlmOptions,
|
||||
groupLlmOptions,
|
||||
} from "@/refresh-components/popovers/LLMPopover";
|
||||
import {
|
||||
Accordion,
|
||||
AccordionContent,
|
||||
AccordionItem,
|
||||
AccordionTrigger,
|
||||
} from "@/components/ui/accordion";
|
||||
import { cn } from "@/lib/utils";
|
||||
|
||||
const MAX_MODELS = 3;
|
||||
|
||||
export interface SelectedModel {
|
||||
name: string;
|
||||
provider: string;
|
||||
modelName: string;
|
||||
displayName: string;
|
||||
}
|
||||
|
||||
export interface ModelSelectorProps {
|
||||
llmManager: LlmManager;
|
||||
selectedModels: SelectedModel[];
|
||||
onAdd: (model: SelectedModel) => void;
|
||||
onRemove: (index: number) => void;
|
||||
onReplace: (index: number, model: SelectedModel) => void;
|
||||
}
|
||||
|
||||
/** Vertical 1px divider between model bar elements */
|
||||
function BarDivider() {
|
||||
return <div className="h-9 w-px bg-border-01 shrink-0" />;
|
||||
}
|
||||
|
||||
/** Individual model pill in the model bar */
|
||||
function ModelPill({
|
||||
model,
|
||||
isMultiModel,
|
||||
onRemove,
|
||||
onClick,
|
||||
}: {
|
||||
model: SelectedModel;
|
||||
isMultiModel: boolean;
|
||||
onRemove?: () => void;
|
||||
onClick?: () => void;
|
||||
}) {
|
||||
const ProviderIcon = getProviderIcon(model.provider, model.modelName);
|
||||
|
||||
return (
|
||||
<div
|
||||
role="button"
|
||||
tabIndex={0}
|
||||
onClick={onClick}
|
||||
onKeyDown={(e) => {
|
||||
if (e.key === "Enter" || e.key === " ") {
|
||||
e.preventDefault();
|
||||
onClick?.();
|
||||
}
|
||||
}}
|
||||
className={cn(
|
||||
"flex items-center gap-0.5 rounded-12 p-2 shrink-0 cursor-pointer",
|
||||
"hover:bg-background-tint-02 transition-colors",
|
||||
isMultiModel && "bg-background-tint-02"
|
||||
)}
|
||||
>
|
||||
<div className="flex items-center justify-center size-5 shrink-0 p-0.5">
|
||||
<ProviderIcon size={16} />
|
||||
</div>
|
||||
<Text mainUiAction text04 nowrap className="px-1">
|
||||
{model.displayName}
|
||||
</Text>
|
||||
{isMultiModel ? (
|
||||
<button
|
||||
type="button"
|
||||
onClick={(e) => {
|
||||
e.stopPropagation();
|
||||
onRemove?.();
|
||||
}}
|
||||
className="flex items-center justify-center size-4 shrink-0 hover:opacity-70"
|
||||
>
|
||||
<SvgX className="size-4 stroke-text-03" />
|
||||
</button>
|
||||
) : (
|
||||
<SvgChevronDown className="size-4 stroke-text-03 shrink-0" />
|
||||
)}
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
/** Model item row inside the add-model popover */
|
||||
function ModelItem({
|
||||
option,
|
||||
isSelected,
|
||||
isDisabled,
|
||||
onToggle,
|
||||
}: {
|
||||
option: LLMOption;
|
||||
isSelected: boolean;
|
||||
isDisabled: boolean;
|
||||
onToggle: () => void;
|
||||
}) {
|
||||
const ProviderIcon = getProviderIcon(option.provider, option.modelName);
|
||||
|
||||
// Build subtitle from model capabilities
|
||||
const subtitle = useMemo(() => {
|
||||
const parts: string[] = [];
|
||||
if (option.supportsReasoning) parts.push("reasoning");
|
||||
if (option.supportsImageInput) parts.push("multi-modal");
|
||||
if (parts.length === 0 && option.modelName) return option.modelName;
|
||||
return parts.join(", ");
|
||||
}, [option]);
|
||||
|
||||
return (
|
||||
<button
|
||||
type="button"
|
||||
disabled={isDisabled}
|
||||
onClick={onToggle}
|
||||
className={cn(
|
||||
"flex items-center gap-1.5 w-full rounded-08 p-1.5 text-left transition-colors",
|
||||
isSelected ? "bg-action-link-01" : "hover:bg-background-tint-02",
|
||||
isDisabled && !isSelected && "opacity-50 cursor-not-allowed"
|
||||
)}
|
||||
>
|
||||
<div className="flex items-center justify-center size-5 shrink-0 p-0.5">
|
||||
<ProviderIcon size={16} />
|
||||
</div>
|
||||
<div className="flex flex-col flex-1 min-w-0">
|
||||
<Text
|
||||
mainUiAction
|
||||
nowrap
|
||||
className={cn(isSelected ? "text-action-link-03" : "text-text-04")}
|
||||
>
|
||||
{option.displayName}
|
||||
</Text>
|
||||
{subtitle && (
|
||||
<Text secondaryBody text03 nowrap>
|
||||
{subtitle}
|
||||
</Text>
|
||||
)}
|
||||
</div>
|
||||
{isSelected && (
|
||||
<Text secondaryBody nowrap className="text-action-link-05 shrink-0">
|
||||
Added
|
||||
</Text>
|
||||
)}
|
||||
</button>
|
||||
);
|
||||
}
|
||||
|
||||
export default function ModelSelector({
|
||||
llmManager,
|
||||
selectedModels,
|
||||
onAdd,
|
||||
onRemove,
|
||||
onReplace,
|
||||
}: ModelSelectorProps) {
|
||||
const [open, setOpen] = useState(false);
|
||||
const [searchQuery, setSearchQuery] = useState("");
|
||||
const scrollContainerRef = useRef<HTMLDivElement>(null);
|
||||
// null = add mode (via + button), number = replace mode (via pill click)
|
||||
const [replacingIndex, setReplacingIndex] = useState<number | null>(null);
|
||||
|
||||
const isMultiModel = selectedModels.length > 1;
|
||||
const atMax = selectedModels.length >= MAX_MODELS;
|
||||
|
||||
const llmOptions = useMemo(
|
||||
() => buildLlmOptions(llmManager.llmProviders),
|
||||
[llmManager.llmProviders]
|
||||
);
|
||||
|
||||
const selectedKeys = useMemo(
|
||||
() => new Set(selectedModels.map((m) => `${m.provider}:${m.modelName}`)),
|
||||
[selectedModels]
|
||||
);
|
||||
|
||||
const filteredOptions = useMemo(() => {
|
||||
if (!searchQuery.trim()) return llmOptions;
|
||||
const query = searchQuery.toLowerCase();
|
||||
return llmOptions.filter(
|
||||
(opt) =>
|
||||
opt.displayName.toLowerCase().includes(query) ||
|
||||
opt.modelName.toLowerCase().includes(query) ||
|
||||
(opt.vendor && opt.vendor.toLowerCase().includes(query))
|
||||
);
|
||||
}, [llmOptions, searchQuery]);
|
||||
|
||||
const groupedOptions = useMemo(
|
||||
() => groupLlmOptions(filteredOptions),
|
||||
[filteredOptions]
|
||||
);
|
||||
|
||||
const isSearching = searchQuery.trim().length > 0;
|
||||
|
||||
// In replace mode, other selected models (not the one being replaced) are disabled
|
||||
const otherSelectedKeys = useMemo(() => {
|
||||
if (replacingIndex === null) return new Set<string>();
|
||||
return new Set(
|
||||
selectedModels
|
||||
.filter((_, i) => i !== replacingIndex)
|
||||
.map((m) => `${m.provider}:${m.modelName}`)
|
||||
);
|
||||
}, [selectedModels, replacingIndex]);
|
||||
|
||||
// Current model at the replacing index (shows as "selected" in replace mode)
|
||||
const replacingKey = useMemo(() => {
|
||||
if (replacingIndex === null) return null;
|
||||
const m = selectedModels[replacingIndex];
|
||||
return m ? `${m.provider}:${m.modelName}` : null;
|
||||
}, [selectedModels, replacingIndex]);
|
||||
|
||||
const getItemState = (optKey: string) => {
|
||||
if (replacingIndex !== null) {
|
||||
// Replace mode
|
||||
return {
|
||||
isSelected: optKey === replacingKey,
|
||||
isDisabled: otherSelectedKeys.has(optKey),
|
||||
};
|
||||
}
|
||||
// Add mode
|
||||
return {
|
||||
isSelected: selectedKeys.has(optKey),
|
||||
isDisabled: !selectedKeys.has(optKey) && atMax,
|
||||
};
|
||||
};
|
||||
|
||||
const handleSelectModel = (option: LLMOption) => {
|
||||
const model: SelectedModel = {
|
||||
name: option.name,
|
||||
provider: option.provider,
|
||||
modelName: option.modelName,
|
||||
displayName: option.displayName,
|
||||
};
|
||||
|
||||
if (replacingIndex !== null) {
|
||||
// Replace mode: swap the model at the clicked pill's index
|
||||
onReplace(replacingIndex, model);
|
||||
setOpen(false);
|
||||
setReplacingIndex(null);
|
||||
setSearchQuery("");
|
||||
return;
|
||||
}
|
||||
|
||||
// Add mode: toggle (add/remove)
|
||||
const key = `${option.provider}:${option.modelName}`;
|
||||
const existingIndex = selectedModels.findIndex(
|
||||
(m) => `${m.provider}:${m.modelName}` === key
|
||||
);
|
||||
if (existingIndex >= 0) {
|
||||
onRemove(existingIndex);
|
||||
} else if (!atMax) {
|
||||
onAdd(model);
|
||||
}
|
||||
};
|
||||
|
||||
const handleOpenChange = (nextOpen: boolean) => {
|
||||
setOpen(nextOpen);
|
||||
if (!nextOpen) {
|
||||
setReplacingIndex(null);
|
||||
setSearchQuery("");
|
||||
}
|
||||
};
|
||||
|
||||
const handlePillClick = (index: number) => {
|
||||
setReplacingIndex(index);
|
||||
setOpen(true);
|
||||
};
|
||||
|
||||
return (
|
||||
<div className="flex items-center justify-end gap-1 p-1">
|
||||
{/* (+) Add model button — hidden at max models */}
|
||||
{!atMax && (
|
||||
<Popover open={open} onOpenChange={handleOpenChange}>
|
||||
<Popover.Trigger asChild>
|
||||
<Button
|
||||
prominence="tertiary"
|
||||
icon={SvgPlusCircle}
|
||||
size="sm"
|
||||
tooltip="Add Model"
|
||||
/>
|
||||
</Popover.Trigger>
|
||||
|
||||
<Popover.Content side="top" align="start" width="lg">
|
||||
<Section gap={0.25}>
|
||||
<InputTypeIn
|
||||
leftSearchIcon
|
||||
variant="internal"
|
||||
value={searchQuery}
|
||||
onChange={(e) => setSearchQuery(e.target.value)}
|
||||
placeholder="Search models..."
|
||||
/>
|
||||
|
||||
<PopoverMenu scrollContainerRef={scrollContainerRef}>
|
||||
{groupedOptions.length === 0
|
||||
? [
|
||||
<div key="empty" className="py-3 px-2">
|
||||
<Text secondaryBody text03>
|
||||
No models found
|
||||
</Text>
|
||||
</div>,
|
||||
]
|
||||
: groupedOptions.length === 1
|
||||
? [
|
||||
<div key="single" className="flex flex-col gap-0.5">
|
||||
{groupedOptions[0]!.options.map((opt) => {
|
||||
const key = `${opt.provider}:${opt.modelName}`;
|
||||
const state = getItemState(key);
|
||||
return (
|
||||
<ModelItem
|
||||
key={opt.modelName}
|
||||
option={opt}
|
||||
isSelected={state.isSelected}
|
||||
isDisabled={state.isDisabled}
|
||||
onToggle={() => handleSelectModel(opt)}
|
||||
/>
|
||||
);
|
||||
})}
|
||||
</div>,
|
||||
]
|
||||
: [
|
||||
<ModelGroupAccordion
|
||||
key="accordion"
|
||||
groups={groupedOptions}
|
||||
isSearching={isSearching}
|
||||
getItemState={getItemState}
|
||||
onToggle={handleSelectModel}
|
||||
/>,
|
||||
]}
|
||||
</PopoverMenu>
|
||||
|
||||
<div className="border-t border-border-01 mt-1 pt-1">
|
||||
<button
|
||||
type="button"
|
||||
className="flex items-center gap-1.5 w-full rounded-08 p-1.5 text-left hover:bg-background-tint-02 transition-colors"
|
||||
>
|
||||
<SvgColumn className="size-5 stroke-text-03 shrink-0" />
|
||||
<Text mainUiAction text04>
|
||||
Compare Model
|
||||
</Text>
|
||||
</button>
|
||||
</div>
|
||||
</Section>
|
||||
</Popover.Content>
|
||||
</Popover>
|
||||
)}
|
||||
|
||||
{/* Divider + model pills */}
|
||||
{selectedModels.length > 0 && (
|
||||
<>
|
||||
<BarDivider />
|
||||
{selectedModels.map((model, index) => (
|
||||
<div
|
||||
key={`${model.provider}:${model.modelName}`}
|
||||
className="flex items-center gap-1"
|
||||
>
|
||||
{index > 0 && <BarDivider />}
|
||||
<ModelPill
|
||||
model={model}
|
||||
isMultiModel={isMultiModel}
|
||||
onRemove={() => onRemove(index)}
|
||||
onClick={() => handlePillClick(index)}
|
||||
/>
|
||||
</div>
|
||||
))}
|
||||
</>
|
||||
)}
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
interface ModelGroupAccordionProps {
|
||||
groups: LLMOptionGroup[];
|
||||
isSearching: boolean;
|
||||
getItemState: (key: string) => { isSelected: boolean; isDisabled: boolean };
|
||||
onToggle: (option: LLMOption) => void;
|
||||
}
|
||||
|
||||
function ModelGroupAccordion({
|
||||
groups,
|
||||
isSearching,
|
||||
getItemState,
|
||||
onToggle,
|
||||
}: ModelGroupAccordionProps) {
|
||||
const allKeys = groups.map((g) => g.key);
|
||||
const [expandedGroups, setExpandedGroups] = useState<string[]>([
|
||||
allKeys[0] ?? "",
|
||||
]);
|
||||
|
||||
const effectiveExpanded = isSearching ? allKeys : expandedGroups;
|
||||
|
||||
return (
|
||||
<Accordion
|
||||
type="multiple"
|
||||
value={effectiveExpanded}
|
||||
onValueChange={(value) => {
|
||||
if (!isSearching) setExpandedGroups(value);
|
||||
}}
|
||||
className="w-full flex flex-col"
|
||||
>
|
||||
{groups.map((group) => {
|
||||
const isExpanded = effectiveExpanded.includes(group.key);
|
||||
return (
|
||||
<AccordionItem
|
||||
key={group.key}
|
||||
value={group.key}
|
||||
className="border-none pt-1"
|
||||
>
|
||||
<AccordionTrigger className="flex items-center rounded-08 hover:no-underline hover:bg-background-tint-02 group [&>svg]:hidden w-full py-1">
|
||||
<div className="flex items-center gap-1 shrink-0">
|
||||
<div className="flex items-center justify-center size-5 shrink-0">
|
||||
<group.Icon size={16} />
|
||||
</div>
|
||||
<Text secondaryBody text03 nowrap className="px-0.5">
|
||||
{group.displayName}
|
||||
</Text>
|
||||
</div>
|
||||
<div className="flex-1" />
|
||||
<div className="flex items-center justify-center size-6 shrink-0">
|
||||
{isExpanded ? (
|
||||
<SvgChevronDown className="h-4 w-4 stroke-text-04 shrink-0" />
|
||||
) : (
|
||||
<SvgChevronRight className="h-4 w-4 stroke-text-04 shrink-0" />
|
||||
)}
|
||||
</div>
|
||||
</AccordionTrigger>
|
||||
<AccordionContent className="pb-0 pt-0">
|
||||
<div className="flex flex-col gap-0.5">
|
||||
{group.options.map((opt) => {
|
||||
const key = `${opt.provider}:${opt.modelName}`;
|
||||
const state = getItemState(key);
|
||||
return (
|
||||
<ModelItem
|
||||
key={key}
|
||||
option={opt}
|
||||
isSelected={state.isSelected}
|
||||
isDisabled={state.isDisabled}
|
||||
onToggle={() => onToggle(opt)}
|
||||
/>
|
||||
);
|
||||
})}
|
||||
</div>
|
||||
</AccordionContent>
|
||||
</AccordionItem>
|
||||
);
|
||||
})}
|
||||
</Accordion>
|
||||
);
|
||||
}
|
||||
Reference in New Issue
Block a user